qadence icon indicating copy to clipboard operation
qadence copied to clipboard

[Enhance] Add support for Python 3.12

Open awennersteen opened this issue 1 year ago • 5 comments

According to https://github.com/pytorch/pytorch/issues/110436 PyTorch 2.2 has at least some Python 3.12 support now.

awennersteen avatar Feb 08 '24 13:02 awennersteen

We should ditch 3.9 then.

RolandMacDoland avatar Feb 09 '24 11:02 RolandMacDoland

Why? 3.9 still has 1 year, 8 months left until EOL.

Agree that if something pops up where we have to change code to build around support both we can ditch 3.9, but why would we ditch it just because?

awennersteen avatar Feb 12 '24 15:02 awennersteen

Why? 3.9 still has 1 year, 8 months left until EOL.

Agree that if something pops up where we have to change code to build around support both we can ditch 3.9, but why would we ditch it just because?

Not just because. My experience is that it is kinda painful to support more than 3 Python versions back. But it is biased because the package contained compiled code. Here, for pure Python, it might be less of a hassle.

RolandMacDoland avatar Feb 13 '24 08:02 RolandMacDoland

@awennersteen Torch doesn't play nicely with py3.12, right ? This is why you closed the issue on PyQ ?

RolandMacDoland avatar Mar 13 '24 18:03 RolandMacDoland

Actually it got sorted with Torch, and in PyQ it's been enabled for 3.12. With the next release of PyQ we can bump it here too

awennersteen avatar Mar 14 '24 11:03 awennersteen

closing since its supported now

dominikandreasseitz avatar May 30 '24 12:05 dominikandreasseitz