pgxmock icon indicating copy to clipboard operation
pgxmock copied to clipboard

Support for `SendBatch`

Open knation opened this issue 3 years ago • 2 comments

Is your feature request related to a problem? Please describe. Missing functionality in mock: SendBatch currently just returns a nil object see here. This does not allow for mocking or testing inputs.

Describe the solution you'd like Implement SendBatch on basic connection and pools. Additionally, create a mock.ExpectSendBatch function to test SendBatch calls in code.

Describe alternatives you've considered Considering changing my code to not use SendBatch just to be able to better test expectations.

Additional context None

knation avatar Dec 29 '21 16:12 knation

Hello. Thanks a lot for your proposal.

I don't remember why I didn't implement this functionality in the first place. I'll try to get back to it ASAP.

If you have an opportunity to provide a pull request for this feature, that would be awesome.

Thanks

pashagolub avatar Jan 14 '22 12:01 pashagolub

Hello, I am interested in this feature too.

LionelCS avatar Jan 20 '22 14:01 LionelCS

Is there any news about this feature?

sejin-P avatar Dec 27 '22 08:12 sejin-P

Hey. Thanks for you interest. I've paused work on this feature due to support of a new major pgx release and a lack of free time.

Feel free to provide a pull request for a review.

Merry Christmas and a happy New year

pashagolub avatar Dec 27 '22 11:12 pashagolub

Ok I will try to support this feature by contribution. Thank you for your answer and a happy new year!

sejin-P avatar Dec 28 '22 00:12 sejin-P

📅 This issue has been automatically marked as stale because lack of recent activity. It will be closed if no further activity occurs. ♻️ If you think there is new information allowing us to address the issue, please reopen it and provide us with updated details. 🤝 Thank you for your contributions.

github-actions[bot] avatar Mar 18 '23 12:03 github-actions[bot]