automerge-action icon indicating copy to clipboard operation
automerge-action copied to clipboard

Usage of `env` over `with` for action configuration

Open Geod24 opened this issue 5 years ago • 1 comments
trafficstars

When setting up this action, I was surprised to see the configuration passed using env instead of with, as described in https://help.github.com/en/actions/building-actions/metadata-syntax-for-github-actions#inputs In essence, it seems that the end result would be pretty much the same ("GitHub stores input parameters as environment variables." according to the doc), but the added bonus is that the input parameters can be documented at the action level (in action.yml).

Geod24 avatar Apr 06 '20 02:04 Geod24

I think the reason is that this action was created before GH added the "with" feature to actions. As far as I know, there is no reason to keep "env", so I think it could make sense to migrate the configuration to use "with".

Feel free to provide a PR, if you like! 👍

pascalgn avatar Apr 06 '20 09:04 pascalgn