question on MERGE_REQUIRED_APPROVALS

Open SamYuan1990 opened this issue 3 years ago • 2 comments

Hi team,

May I know for MERGE_REQUIRED_APPROVALS, will this count for maintainers? or it will count all accounts?

Thanks and regards Sam

Sep 27 '22 13:09 SamYuan1990

I think it will count all accounts. I might be wrong, but I think in the past it wasn't possible to give "approval" reviews in repositories where one doesn't have write access to. But anyways, now it looks like it's possible, so the MERGE_REQUIRED_APPROVALS should only count reviews of people who have write access...

Oct 07 '22 19:10 pascalgn

I think it will count all accounts. I might be wrong, but I think in the past it wasn't possible to give "approval" reviews in repositories where one doesn't have write access to. But anyways, now it looks like it's possible, so the MERGE_REQUIRED_APPROVALS should only count reviews of people who have write access...

ok, so once this one been fixed, we may able to have a try via https://github.com/sustainable-computing-io/kepler/issues/249

Oct 08 '22 04:10 SamYuan1990