Pascal Duez

Results 183 comments of Pascal Duez

> For me at least, writing type tests is the biggest time suck when making large libdefs. Yes, we should probably be flexible here, for large libdefs, maybe only the...

Looks like you need to pass a generic somewhere. Have a look at the library definitions tests for usage examples.

Hi @FezVrasta, could be nice. How would that work with tests files? :sweat_smile:

That's because the [`resolves`](https://github.com/flow-typed/flow-typed/blob/cc44a27e8f1fb6335c27f7dd702b9fcec2bfd330/definitions/npm/jest_v24.x.x/flow_v0.104.x-/jest_v24.x.x.js#L148), and `rejects` methods only are bound to `JestExpectType` where they should have the whole list of plugins as well. Which will start to become a bit...

@jedwards1211 > IRC the syntax doesn't even support explicitly specifying the parameters in a function call like that (unlike generics in other languages like Java). FWIW it's supported from version...

Not 100% sure of what's going on, but [looking at the libdef](https://github.com/flow-typed/flow-typed/blob/c87d478d4c4561dc168076ad1c56bf3b4b39bcae/definitions/npm/%40reach/router_v1.1.x/flow_v0.104.x-/router_v1.1.x.js#L74) looks quite a good path for problems. Spreading a `$Shape` of a Class in an inexact object...

> Looking at the libdef for HTMLAnchorElement, I'm seeing those props as required. That's probably the issue. It's a `class`.

See https://github.com/flow-typed/flow-typed/pull/3546

@HenryKenya I'm pretty sure #3546 won't get any attention anymore. Would you be willing to take it over? Maybe create another MR with the fix, and more importantly, write extensive...