Patrick Quist

Results 554 comments of Patrick Quist

They were recently added in a PR (https://github.com/compiler-explorer/compiler-explorer/pull/4068), but I now notice they are using the wrong gcc toolchain paths, hence the not finding the c headers. The compilers were...

Fixed in https://github.com/compiler-explorer/compiler-explorer/commit/f22a2a3a782a22e820ae57f3daa755c55347fbd0 (not live yet) Still need to add to c++

I think at some point we fixed it, but then it another bug was filed that we were using the wrong target architecture. So basically clang arm is a unknown...

ah and https://github.com/compiler-explorer/compiler-explorer/commit/f22a2a3a782a22e820ae57f3daa755c55347fbd0 only applied to specific versions

So sort of related to https://github.com/compiler-explorer/compiler-explorer/issues/3868

Sorry, we had a wrong setting somewhere. It should be now fixed

This is maybe an Ok change, but calling in @OfekShilon and @mattgodbolt It might be appropriate to only hide these when comments are filtered out, but not sure

Interestingly https://github.com/compiler-explorer/compiler-explorer/issues/4130, https://github.com/compiler-explorer/compiler-explorer/issues/297, https://github.com/compiler-explorer/compiler-explorer/issues/1004 are about GCC, and there it's off by default and if on - most comments are removed by comment filter I don't know, I'm conflicted. The...

> @verhovsky I assume you're talking about my suggestion `options.push(filters.commentOnly ? '-fno-verbose-asm' : '-fverbose-asm');`. Indeed I intended for this to be in `BaseCompiler.optionsForFilter` and not `Clang.optionsForFilter` - as said later...

> > Where is the question? > > I was asking whether these two lines are needed: > > ``` > if (!this.compiler.supportsOptOutput) this.compiler.supportsOptOutput = false; > if (!this.compiler.supportsVerboseAsm) this.compiler.supportsVerboseAsm...