partiql-lang-kotlin
partiql-lang-kotlin copied to clipboard
partiql
PartiQL libraries and tools in Kotlin.
- There are many tests still using JUnit 4. - There are now many test classes which mix JUnit 5's annotations and JUnit 4's assertions, which is messy. - JUnit...
As mentioned in https://github.com/partiql/partiql-lang-kotlin/pull/573#discussion_r848788874, `TestBase` inherits from `org.junit.Assert`, which is how most of the inheriting test classes access the `assert*` methods (through Assert's protected methods.) This is disadvantages because these...
I think the test case here is wrong: https://github.com/partiql/partiql-lang-kotlin/blob/3febaeec46a0b703781494699c445f2034e9c6c4/lang/test/org/partiql/lang/eval/EvaluatingCompilerExceptionsTest.kt#L91-L96 This may seem counterintuitive... However... if my read of section 3.4 of the [PartiQL specification](https://partiql.org/assets/PartiQL-Specification.pdf) is correct, this should not actually...
When https://github.com/partiql/partiql-ir-generator/issues/112 has completed, utilize it here in the code base.
Since we're generally moving toward `IonElement` over `IonValue` in many places of PartiQL, it would be good if we can eliminate the dependency on `IonSystem` from the [`SqlParser`](https://github.com/partiql/partiql-lang-kotlin/blob/7f07dc31570f4e10e4e433a8878e35416771d6f7/lang/src/org/partiql/lang/syntax/SqlParser.kt#L82) and [`SqlLexer`](https://github.com/partiql/partiql-lang-kotlin/blob/7f07dc31570f4e10e4e433a8878e35416771d6f7/lang/src/org/partiql/lang/syntax/SqlLexer.kt#L30)...
The big feature we need here is the [explicit API mode for library authors](https://kotlinlang.org/docs/reference/whatsnew14.html#explicit-api-mode-for-library-authors), which makes missing visibility specifiers that are exposed to the public API either a warning or...
The current implementation of `expectVariableReferences` checks for the matched `expectation` for `VariableReference` and removes the same from `remainingExpectations`. This logic fails when the `VariableReference` is visited again and throws error....
(related to https://github.com/partiql/partiql-lang-kotlin/issues/514) The `isNullable` and `isOptional` functions in `StaticTypeMapper.kt` can be removed once the tests are added. Source of the functions in `StaticTypeMapper`: https://github.com/partiql/partiql-lang-kotlin/blob/fb7992468158d947557dc979f48a5f41ce83aa43/lang/src/org/partiql/lang/mappers/StaticTypeMapper.kt#L23-L25