device-os icon indicating copy to clipboard operation
device-os copied to clipboard

Add missing DYNALIB_FNs for os_thread_{wait,notify}

Open metcalf opened this issue 2 years ago • 1 comments

Problem

/Users/andrew/code/supply_ventilation//src/DisplayTask.cpp:51: undefined reference to `os_thread_notify'
/Users/andrew/.particle/toolchains/gcc-arm/10.2.1/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: ../../../build/target/user/platform-6-m/supply_ventilation//libuser.a(DisplayTask.o): in function `DisplayTask::_taskFun()':
/Users/andrew/code/supply_ventilation//src/DisplayTask.cpp:59: undefined reference to `os_thread_wait'
collect2: error: ld returned 1 exit status

Solution

Added missing DYNALIB_FN entries for os_thread_{wait,notify}

Steps to Test

I assume existing compilation/tests would break if I

Example App

N/A

References

Completeness

  • [x] User is totes amazing for contributing!
  • [ ] Contributor has signed CLA (Info here)
  • [ ] Problem and Solution clearly stated
  • [ ] Run unit/integration/application tests on device
  • [ ] Added documentation
  • [ ] Added to CHANGELOG.md after merging (add links to docs and issues)

metcalf avatar Sep 16 '21 17:09 metcalf

Hmm, maybe this isn't an API that's intended to be exposed directly given the existence of the Thread class? Should Thread support these methods?

metcalf avatar Sep 16 '21 18:09 metcalf