parthenon icon indicating copy to clipboard operation
parthenon copied to clipboard

WIP: Change deprecated kokkos-num-devices to kokkos-map-device-id for ctest

Open forrestglines opened this issue 1 year ago • 1 comments

PR Summary

Apparently the kokkos command line option --kokkos-num-devices is deprecated Per Kokkos' suggestion changing this in testing to --kokkos-map-device-id-by=mpi_rank allows us to forgo specifying NUM_GPU_DEVICES_PER_NODE, making building+testing simpler.

PR Checklist

  • [ ] Code passes cpplint
  • [ ] New features are documented.
  • [ ] Adds a test for any bugs fixed. Adds tests for new features.
  • [ ] Code is formatted
  • [ ] Changes are summarized in CHANGELOG.md
  • [ ] CI has been triggered on Darwin for performance regression tests.
  • [ ] Docs build
  • [ ] (@lanl.gov employees) Update copyright on changed files

forrestglines avatar Aug 30 '23 20:08 forrestglines

Do we want to get rid of that parameter entirely? As far as I can tell it's only used in the "test precheck" as a warning, but otherwise the numbers are hardcoded to each machine in the machine file anyway.

pgrete avatar Sep 22 '23 13:09 pgrete