parthenon icon indicating copy to clipboard operation
parthenon copied to clipboard

Support for File Formats

Open JoshuaSBrown opened this issue 4 years ago • 6 comments

I would like to start a discussion based on our conversation about support for different file formats and how to approach this moving forwards.

There was the suggestion I believe by @nmsriram that we should avoid supporting any file formats outside of hdf5 because it will be a maintenance burden.

The counter argument provided by @jmstone was that hdf5 can sometimes prove difficult to configure and it would be nice to have something that works out of the box from a user perspective.

My personal opinion is that supporting one alternative file format from hdf5 will be a good idea. For any others I think it would be nice to have a plugin type interface where users can design and support their own. In LAMMPS they have a similar approach for user designed features. The feature code is placed in a folder and the developer is responsible for problems. To use the package/plugin one has to turn on a build flag to enable it. I could envision something similar. Any other thoughts or ideas?

JoshuaSBrown avatar Oct 08 '20 19:10 JoshuaSBrown

I like the idea of a plugin interface quite a lot.

Yurlungur avatar Oct 09 '20 20:10 Yurlungur

I actually think some additional interfaces should live in Parthenon. In the end I don't expect there to be any major maintenance burden. The codes I've been working on so far basically never changed the output definitions used (independent of the file format) and I would also strongly argue for a very stable output format.

pgrete avatar Oct 16 '20 15:10 pgrete

As pointed out by @bprather and others at parthenon meeting, sliced text output could be nice.

Yurlungur avatar Oct 07 '22 22:10 Yurlungur

Discussion relevant for ADIOS (issue #946) and histograms (PR #962 ). For #962 it could be nice to support an ASCII output version for histograms. (Not urgent.)

Yurlungur avatar Dec 13 '23 00:12 Yurlungur

Would ASCII output be okay in json (as openPMD has a json backend)?

pgrete avatar Dec 13 '23 10:12 pgrete

Json isn’t very human readable but it’ll do!

Get Outlook for iOShttps://aka.ms/o0ukef


From: Philipp Grete @.> Sent: Wednesday, December 13, 2023 3:25:55 AM To: parthenon-hpc-lab/parthenon @.> Cc: Subscribed @.***> Subject: [EXTERNAL] Re: [parthenon-hpc-lab/parthenon] Support for File Formats (#318)

Would ASCII output be okay in json (as openPMD has a json backend)?

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/parthenon-hpc-lab/parthenon/issues/318*issuecomment-1853648031__;Iw!!Bt8fGhp8LhKGRg!Cf3HTgom-ICBzyJsm_ERGq9je9pHp6REoWpR3U8PssMDYnOpBNV8X8vRG7P15HeHEv3gIJYuhgA31PFeIANtwgF6$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOO5OJ5ZCJVH2EGWFWLVKELYJF7DHAVCNFSM4SJF5VB2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBVGM3DIOBQGMYQ__;!!Bt8fGhp8LhKGRg!Cf3HTgom-ICBzyJsm_ERGq9je9pHp6REoWpR3U8PssMDYnOpBNV8X8vRG7P15HeHEv3gIJYuhgA31PFeICKC7qia$. You are receiving this because you are subscribed to this thread.Message ID: @.***>

jonahm-LANL avatar Dec 13 '23 14:12 jonahm-LANL