parthenon icon indicating copy to clipboard operation
parthenon copied to clipboard

Add time offset for LowStorageIntegrator

Open pbrady opened this issue 1 year ago • 4 comments

PR Summary

I was wanting to supply a time dependent source term (for manufactured solutions) using the LowStorageIntegrator and didn't see a direct way to access the time level associated with each stage. I followed the procedure in Ketcheson 2010 to compute the Butcher table coefficients for the methods. The resulting cs were tested out in a Mathematica notebook and recovered the expected order of accuracy.

PR Checklist

  • [ ] Code passes cpplint
  • [x] New features are documented.
  • [ ] Adds a test for any bugs fixed. Adds tests for new features.
  • [ ] Code is formatted
  • [x] Changes are summarized in CHANGELOG.md
  • [ ] Change is breaking (API, behavior, ...)
    • [ ] Change is additionally added to CHANGELOG.md in the breaking section
    • [ ] PR is marked as breaking
    • [ ] Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • [ ] CI has been triggered on Darwin for performance regression tests.
  • [ ] Docs build
  • [ ] (@lanl.gov employees) Update copyright on changed files

pbrady avatar Aug 09 '24 19:08 pbrady

Seems like a CI failure:

Error: Could not find file '/home/runner/work/_actions/_temp_68ccd911-c253-4309-82e1-094e899b9ceb/_staging/gregsdennis-dependencies-action-f4fa194/node_modules/.bin/esparse'.

pbrady avatar Aug 12 '24 14:08 pbrady

Seems like a CI failure:

Error: Could not find file '/home/runner/work/_actions/_temp_68ccd911-c253-4309-82e1-094e899b9ceb/_staging/gregsdennis-dependencies-action-f4fa194/node_modules/.bin/esparse'.

Yes, somehow the automated docker image cleanup didn't work as expected. I'm looking into it.

pgrete avatar Aug 13 '24 07:08 pgrete

Seems like a CI failure:

Error: Could not find file '/home/runner/work/_actions/_temp_68ccd911-c253-4309-82e1-094e899b9ceb/_staging/gregsdennis-dependencies-action-f4fa194/node_modules/.bin/esparse'.

Yes, somehow the automated docker image cleanup didn't work as expected. I'm looking into it.

Things should work as before again.

pgrete avatar Aug 14 '24 12:08 pgrete

I've updated the docs and changelog. Computing c is more of an algorithm than a formula so I referenced the paper instead of repeating the algorithm.

pbrady avatar Aug 14 '24 20:08 pbrady

CI failing. @pbrady will plan to add mathematica notebook.

Yurlungur avatar Aug 22 '24 16:08 Yurlungur

Mathematica notebook added

pbrady avatar Aug 23 '24 20:08 pbrady

I removed the binary parts (mostly the rendered images) from the notebook file as they don't render on Github anyway (and added one sentence pointing to the notebook in both the docs in head file). Any objections?

pgrete avatar Aug 26 '24 07:08 pgrete

No objections here.

pbrady avatar Aug 26 '24 13:08 pbrady