athenapk

athenapk copied to clipboard

Style for parameter files and documentation of parameters

1

Following up from https://gitlab.com/theias/hpc/jmstone/athena-parthenon/athenapk/-/issues/6 it might be good to discuss a common style for parameter file (e.g., handling of units) https://gitlab.com/theias/hpc/jmstone/athena-parthenon/athenapk/-/issues/3 is also related, i.e., to add a sample input...

pgrete

Make injected magnetic vector potential in the magnetic tower feedback in order to avoid allocating+deallocating a vector potential field every time the magnetic tower is injected.

forrestglines

The Parthenon reflecting boundary conditions do not work correctly in AthenaPK, because AthenaPK allocates variables in a different way from other Parthenon codes. I will add custom boundary conditions for...

BenWibking

Unify treatment of mean molecular mass and temperature

2

As mentioned in #2 about `src/cluster/agn_triggering.cpp`, it would be best to unify treatment of He mass fraction, mean molecular mass, and computing temperature.

forrestglines

Adding "physics-based" reconstruction

2

For various things, it would be useful to reconstruct a different set of variables other than the primitive variables. For example, we might want to reconstruct (density, velocity, temperature) instead,...

BenWibking

Magnetic field handling for non-periodic boundary conditions

1

We likely need to take special care of the B fields around non-periodic boundaries, so that we do not introduce div B from there. This likely also pertains to prolongation/restriction...

pgrete

Depending on the type of source (split/unsplit), we need to take special care of the content in the the `prim` and `cons` registers and their update (so that multiple split...

pgrete

Implement xsPPM7 reconstruction

1

@BenWibking opened on GitLab https://gitlab.com/theias/hpc/jmstone/athena-parthenon/athenapk/-/issues/15: This method is described in: Rider, Greenough, and Kamm (JCP, Vol. 225, 2, p. 1827-1848): https://ui.adsabs.harvard.edu/abs/2007JCoPh.225.1827R/abstract. I tested this method in conjunction with RK2, but...

pgrete

Add shock flattener

1

@BenWibking reported on https://gitlab.com/theias/hpc/jmstone/athena-parthenon/athenapk/-/issues/14: It would be very useful to implement the shock flattener from Miller & Colella (2002): https://ui.adsabs.harvard.edu/abs/2002JCoPh.183...26M/abstract Thread: > @pgrete FYI (not sure if you've seen it),...

pgrete

Add option to use `mbar` when using physical temperatures

1

Migrated from GitLab: https://gitlab.com/theias/hpc/jmstone/athena-parthenon/athenapk/-/issues/8: In the future, mbar might be the more generalizable parameter for defining the temperature. We could add it as an alternative to defining He_mass_fraction. However, since...

pgrete