Parth

Results 103 comments of Parth

We would need to find a way, on Clad side of things, to associate every `CladFunction` object with the corresponding derived function it stores. Then we would need to traverse...

I want to understand the issue in more detail. > which goes ahead and accesses the non-owning m_Sources. Please correct me if I am wrong, but isn't `m_ExternalSource` the exclusive...

Sorry, I did not see your last comment before. > No, I am talking about the pointers that m_Sources holds. Those are sll raw pointers that don't signify any kind...

> What do you think about changing sources type from raw pointer to unique_ptr? This will solve the ownership problem. And of course, any of the solutions that you suggested...

> I would suggest anything other than uniqiue_ptr because technically that pointer is shared between the m_Sources and the owner themselves. `unique_ptr` approach, by means of move semantics, would typically...

> The whole point of this question is that `m_Sources` does not own the object it holds. Hence, make no sense to use unique_ptr here because that then implies that...

We should first discuss and decide what design we want for the `MultiplexExternalRMVSource`. We have a few options: - Design `MultiplexExternalRMVSource` to be an exclusive owner of all external sources...

> Is this fine? Yes, definitely. Feel free to ping here if you face any issues while adding test for these functions.

> can you also just mark what goes in the readme and what in readthedocs? All of these tasks should go in the readthedocs. I will mention this in the...

> fill out the information in what can be differentiated. I am not sure if we should keep this section in the GitHub Readme. We want the GitHub readme to...