parseable icon indicating copy to clipboard operation
parseable copied to clipboard

FIX: Windows failing build and querying

Open parmesant opened this issue 3 months ago • 0 comments

Fixes #824 and Failing builds on windows

Description

For #824, the file path being passed to PartitionedFile struct is being modified if the storage_mode is drive (for s3-store, and blob-store the current code works just fine)

For failing windows builds, a cfg!() is added to tokio::select! macro to handle different signals for different underlying OS


This PR has:

  • [x] been tested to ensure log ingestion and log query works.
  • [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • [x] added documentation for new or modified features or behaviors.

parmesant avatar Oct 28 '24 13:10 parmesant