parseable icon indicating copy to clipboard operation
parseable copied to clipboard

Alert timing

Open de-sh opened this issue 3 years ago • 0 comments

Fixes #XXXX.

Description

Adds code to manage time periods within which the alert rule is valid.

Possible loopholes: The current behavior only considers first event only for setting period_end, so lets say the range is 5s and there are events that come in at 0s, 2s, 3s, 4s, 5s, 6s, 7s, at 6s, reset will cause loss of information, and we will have to restart from 6s until 11s or so on. Could this be bad design?


This PR has:

  • [x] been tested to ensure log ingestion and log query works.
  • [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • [ ] added documentation for new or modified features or behaviors.

de-sh avatar Aug 24 '22 13:08 de-sh