parse-server icon indicating copy to clipboard operation
parse-server copied to clipboard

refactor: Reorganize transformInteriorValue

Open kassiansun opened this issue 11 months ago • 6 comments

Pull Request

Issue

This code was checking a constantly true condition value !== CannotTransform, that's why the code was not properly handling nested structure properly, The code introduced by #8446 fixed this logic, by introducing another duplicated piece of code.

Closes: #9567

Approach

This commit simplifies the logic here to reflect the original purpose.

kassiansun avatar Jan 22 '25 06:01 kassiansun

I will reformat the title to use the proper commit message syntax.

🚀 Thanks for opening this pull request!

This PR should also fix the (broken since #8446) regexp and bytes conversion, althought I didn't try to test it

kassiansun avatar Jan 22 '25 07:01 kassiansun

@kassiansun Thank you for the PR, and you patience in waiting for review. I've rebased it and restarted the CI.

mtrezza avatar Apr 07 '25 16:04 mtrezza

You removed a few handling cases, what is the purpose of this, shouldn't the removed cases be handled as well?

These cases are handled later in the function, the logic was duplicated twice

kassiansun avatar Apr 11 '25 07:04 kassiansun

Could you provide more details? Where are they handled?

mtrezza avatar Apr 11 '25 10:04 mtrezza