refactor: Reorganize transformInteriorValue
Pull Request
- Report security issues confidentially.
- Any contribution is under this license.
- Link this pull request to an issue.
Issue
This code was checking a constantly true condition value !== CannotTransform, that's why the code was not properly handling nested structure properly, The code introduced by #8446 fixed this logic, by introducing another duplicated piece of code.
Closes: #9567
Approach
This commit simplifies the logic here to reflect the original purpose.
I will reformat the title to use the proper commit message syntax.
🚀 Thanks for opening this pull request!
This PR should also fix the (broken since #8446) regexp and bytes conversion, althought I didn't try to test it
@kassiansun Thank you for the PR, and you patience in waiting for review. I've rebased it and restarted the CI.
You removed a few handling cases, what is the purpose of this, shouldn't the removed cases be handled as well?
These cases are handled later in the function, the logic was duplicated twice
Could you provide more details? Where are they handled?