parse-server icon indicating copy to clipboard operation
parse-server copied to clipboard

test: Failing test case for constraint notEqualTo null

Open RahulLanjewar93 opened this issue 1 year ago • 6 comments

failing Test case for issue #8834 adding this so pr is not closed. closes #8834

image

RahulLanjewar93 avatar Dec 14 '23 09:12 RahulLanjewar93

I will reformat the title to use the proper commit message syntax.

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

This test does not expect anything, please add a check to the test

Actually, the server itself crashes since we are not handling the error thrown inside matchesKeyConstraints. Which is why i have not added any expect

RahulLanjewar93 avatar Dec 16 '23 06:12 RahulLanjewar93

I will reformat the title to use the proper commit message syntax.

I believe the test looks good now; do you have any suggestion for a fix?

mtrezza avatar Dec 16 '23 20:12 mtrezza

I believe the test looks good now; do you have any suggestion for a fix?

https://github.com/parse-community/parse-server/blob/2c2563ebd2ac5255b387296a563a34157ec076f5/src/LiveQuery/QueryTools.js#L226

this line should have optional chaining in my opinion

RahulLanjewar93 avatar Dec 16 '23 20:12 RahulLanjewar93

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.15%. Comparing base (716925e) to head (532a2ed).

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #8835   +/-   ##
=======================================
  Coverage   94.15%   94.15%           
=======================================
  Files         186      186           
  Lines       14726    14726           
=======================================
  Hits        13865    13865           
  Misses        861      861           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 11 '24 14:06 codecov[bot]

🎉 This change has been released in version 7.1.0-alpha.10

parseplatformorg avatar Jun 11 '24 19:06 parseplatformorg

🎉 This change has been released in version 7.1.0-beta.1

parseplatformorg avatar Jun 30 '24 02:06 parseplatformorg

🎉 This change has been released in version 7.1.0

parseplatformorg avatar Jun 30 '24 02:06 parseplatformorg