parse-server icon indicating copy to clipboard operation
parse-server copied to clipboard

test: Add test for incrementing number atomically

Open theolundqvist opened this issue 2 years ago • 5 comments

Pull Request

Issue

Closes: #8772 (cloud increment atomicity not working)

Approach

There does not seem to be a test that tests proper atomicity. This should be granted by mongo but here we are anyways.

Tasks

  • [x] Add tests

theolundqvist avatar Oct 24 '23 17:10 theolundqvist

Thanks for opening this pull request!

I will reformat the title to use the proper commit message syntax.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.47%. Comparing base (9552a4c) to head (6f52f4d).

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #8789   +/-   ##
=======================================
  Coverage   93.46%   93.47%           
=======================================
  Files         186      186           
  Lines       14806    14806           
=======================================
+ Hits        13839    13840    +1     
+ Misses        967      966    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 27 '23 13:11 codecov[bot]

@theolundqvist the tests have passed; does that mean that there is no issue with atomically incrementing?

mtrezza avatar Mar 25 '24 00:03 mtrezza

@mtrezza I'm not so sure about that, I believe they passed when I created them. But I still had trouble with it.

I am not invested in the parse platform anymore so do not have time to run further experiments.

theolundqvist avatar Mar 25 '24 04:03 theolundqvist