parse-server icon indicating copy to clipboard operation
parse-server copied to clipboard

feat: add custom objectId by providing newObjectIdCallback from server config

Open JasCodes opened this issue 3 years ago • 4 comments

Features

  • Add custom objectId by providing newObjectIdCallback from server config.
  • [x] I am not disclosing a vulnerability.
  • [x] I am creating this PR in reference to an issue.

Issue Description

Related issue:

  • Fixes #7830

Approach

TODOs before merging

  • [ ] Add tests
  • [ ] Add changes to documentation (guides, repository pages, in-code descriptions)

JasCodes avatar Mar 04 '22 18:03 JasCodes

I will reformat the title to use the proper commit message syntax.

@mtrezza Can you approve workflows?

JasCodes avatar Mar 04 '22 18:03 JasCodes

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

Sure, we can run the workflow, but we do this usually as the last steps to ensure your code works in all supported environments. Until the PR is ready, you can run the tests locally in your local environment to see whether they pass. That's also faster during development, as you can choose to run only your own tests that you add as part of this PR.

This PR still needs:

  • Tests, see existing tests in /spec folder for guidance
  • Adding the new Parse server option, see Contribution Guide for the necessary steps

mtrezza avatar Mar 04 '22 20:03 mtrezza