parse-server icon indicating copy to clipboard operation
parse-server copied to clipboard

test: increase coverage

Open dblythy opened this issue 3 years ago • 4 comments

New Pull Request Checklist

  • [x] I am not disclosing a vulnerability.
  • [x] I am creating this PR in reference to an issue.

Issue Description

Increases coverage by adding some more tests

Related issue: #7563

Approach

Adds a few more test cases

TODOs before merging

  • [x] Add test cases

dblythy avatar Oct 26 '21 10:10 dblythy

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

Codecov Report

Base: 94.27% // Head: 94.07% // Decreases project coverage by -0.20% :warning:

Coverage data is based on head (737c3ff) compared to base (6323368). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 737c3ff differs from pull request most recent head 4d3bf0f. Consider uploading reports for the commit 4d3bf0f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #7654      +/-   ##
==========================================
- Coverage   94.27%   94.07%   -0.21%     
==========================================
  Files         180      180              
  Lines       13987    13984       -3     
==========================================
- Hits        13186    13155      -31     
- Misses        801      829      +28     
Impacted Files Coverage Δ
src/cli/parse-server.js 70.31% <ø> (+37.50%) :arrow_up:
src/cli/utils/runner.js 100.00% <100.00%> (+13.63%) :arrow_up:
src/Adapters/Cache/RedisCacheAdapter.js 15.55% <0.00%> (-75.56%) :arrow_down:
src/LiveQuery/ParseCloudCodePublisher.js 83.33% <0.00%> (-16.67%) :arrow_down:
src/Routers/AggregateRouter.js 92.00% <0.00%> (-8.00%) :arrow_down:
src/ParseServerRESTController.js 92.42% <0.00%> (-6.07%) :arrow_down:
src/batch.js 89.47% <0.00%> (-5.27%) :arrow_down:
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 90.63% <0.00%> (-2.35%) :arrow_down:
src/Adapters/Files/GridFSBucketAdapter.js 93.43% <0.00%> (-0.73%) :arrow_down:
src/RestWrite.js 94.61% <0.00%> (-0.30%) :arrow_down:
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 26 '21 10:10 codecov[bot]

@dblythy Is this ready for review?

mtrezza avatar Mar 22 '22 23:03 mtrezza

Just need to get tests to pass

dblythy avatar Mar 26 '22 04:03 dblythy

I will reformat the title to use the proper commit message syntax.