parse-server icon indicating copy to clipboard operation
parse-server copied to clipboard

Implemented auth0 adapater.

Open lukasredev opened this issue 4 years ago • 3 comments

New Pull Request Checklist

  • [x] I am not disclosing a vulnerability.
  • [x] I am creating this PR in reference to an issue.

Issue Description

Implements https://github.com/parse-community/parse-server/issues/7478

Approach

I followed a similar approach to the apple authentication adapter.

Documentation PR: https://github.com/parse-community/docs/pull/843

TODOs before merging

  • [x] Add test cases
  • [ ] Add entry to changelog
  • [x] Add changes to documentation (guides, repository pages, in-code descriptions)
  • [ ] Add security check
  • [ ] Add new Parse Error codes to Parse JS SDK
  • [ ] ...

lukasredev avatar Aug 19 '21 08:08 lukasredev

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.43 :warning:

Comparison is base (c9b5971) 94.37% compared to head (79e4857) 93.95%.

:exclamation: Current head 79e4857 differs from pull request most recent head 32a9aad. Consider uploading reports for the commit 32a9aad to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #7502      +/-   ##
==========================================
- Coverage   94.37%   93.95%   -0.43%     
==========================================
  Files         185      182       -3     
  Lines       14761    13314    -1447     
==========================================
- Hits        13931    12509    -1422     
+ Misses        830      805      -25     
Impacted Files Coverage Δ
src/Adapters/Auth/auth0.js 100.00% <100.00%> (ø)
src/Adapters/Auth/index.js 93.65% <100.00%> (-4.50%) :arrow_down:

... and 144 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 19 '21 09:08 codecov[bot]

@lukasreichart would you want to make the suggested changes, so we can merge this?

mtrezza avatar Jul 14 '23 00:07 mtrezza

@mtrezza Is there any updates on this PR?

am2222 avatar Nov 17 '23 14:11 am2222