parse-server-gcs-adapter icon indicating copy to clipboard operation
parse-server-gcs-adapter copied to clipboard

Makes createFile explicit non-resumable uploads by default. Useful to…

Open tindice opened this issue 8 years ago • 4 comments

… fastest small files uploads.

tindice avatar Feb 04 '17 01:02 tindice

Codecov Report

Merging #17 into master will increase coverage by 0.55%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   51.38%   51.94%   +0.55%     
==========================================
  Files           1        1              
  Lines          72       77       +5     
  Branches       12       13       +1     
==========================================
+ Hits           37       40       +3     
- Misses         35       37       +2
Impacted Files Coverage Δ
index.js 51.94% <66.66%> (+0.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e70213b...bb15dfc. Read the comment docs.

codecov-io avatar Feb 04 '17 01:02 codecov-io

I guess it should be better to expose the option, but I really needed the change to prevent my setup to become unresponsive during high loads (file migration from legacy files)

tindice avatar Feb 04 '17 01:02 tindice

Could you expose the option in the adapter constructor?

flovilmart avatar Feb 04 '17 12:02 flovilmart

Hi @flovilmart

I did the changes, what do you think? Ultimately the ability of being resumable or not can be chosen per file, that's why I included it on createFile, but it will default to whatever is used on the constructor if not specified.

cheers

tindice avatar Feb 13 '17 23:02 tindice