parse-dashboard icon indicating copy to clipboard operation
parse-dashboard copied to clipboard

change row deletion confirm text in dialog

Open sadakchap opened this issue 2 years ago • 1 comments

New Pull Request Checklist

  • [x] I am not disclosing a vulnerability.
  • [x] I am creating this PR in reference to an issue.

Issue Description

UX issue. The confirmation dialog to delete selected rows, to delete all rows and to delete the whole class require to enter the class name. All 3 dialogs look similar. The issue is that the dialogs may be mistaken for each other. Also the buttons in the menu to perform these actions are next to each other.

Related issue: #2239

Approach

Updated RowDeleteDialog component, to show different confirmation text based on row selection(props.selection).

selection length >= 10 --> confirmationText = "delete selected" selected all --> confirmationText = "delete all"

Note: for deleting whole class there is different dialog component(No changes there).

TODOs before merging

  • [ ] Add tests
  • [ ] Add changes to documentation (guides, repository pages, in-code descriptions)
  • [x] A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

sadakchap avatar Oct 14 '22 02:10 sadakchap

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@sadakchap When this is ready for review, kindly request a review from @parse-community/dashboard-review

mtrezza avatar Oct 14 '22 11:10 mtrezza

I think this pr ready for a review. @parse-community/dashboard-review Please let me know about your thoughts.

sadakchap avatar Oct 15 '22 03:10 sadakchap

🎉 This change has been released in version 5.0.0-alpha.5

parseplatformorg avatar Oct 15 '22 14:10 parseplatformorg

🎉 This change has been released in version 5.0.0-beta.1

parseplatformorg avatar Oct 17 '22 17:10 parseplatformorg

🎉 This change has been released in version 5.0.0

parseplatformorg avatar Nov 01 '22 20:11 parseplatformorg