parse-dashboard icon indicating copy to clipboard operation
parse-dashboard copied to clipboard

Change row batch deletion confirmation entry

Open mtrezza opened this issue 2 years ago • 4 comments

New Issue Checklist

Issue Description

This is a UX issue. The confirmation dialog to delete selected rows, to delete all rows and to delete the whole class require to enter the class name. All 3 dialogs look similar. The issue is that the dialogs may be mistaken for each other. Also the buttons in the menu to perform these actions are next to each other.

Screen Shot 2022-08-16 at 11 38 04 Screen Shot 2022-08-16 at 11 30 37 Screen Shot 2022-08-16 at 11 24 38 Screen Shot 2022-08-16 at 11 24 28

Steps to reproduce

  1. Delete selected rows
  2. Delete all rows
  3. Delete class

Actual Outcome

Described above

Expected Outcome

Make the dialogs more distinguishable, for example:

  • The dialog to delete N rows should not request to enter the class name but the word "delete selected"
  • The dialog to delete all rows should not request to enter the class name but the word "delete all".
  • The dialog to delete the whole class should stay as is and request to enter the class name.

Environment

Dashboard

  • Parse Dashboard version: 4.1.4

Logs

n/a

mtrezza avatar Aug 16 '22 09:08 mtrezza

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza Can I please take a stab at this issue?

sadakchap avatar Oct 13 '22 10:10 sadakchap

Please feel free, it doesn't seem that anyone is working on this as there's no comment

cc @Magdaraa

mtrezza avatar Oct 13 '22 11:10 mtrezza

Thank you @mtrezza . Here's the pr https://github.com/parse-community/parse-dashboard/pull/2319. Please let me know about your thoughts.

sadakchap avatar Oct 14 '22 02:10 sadakchap

Closing via #2319

mtrezza avatar Oct 15 '22 14:10 mtrezza