parse-dashboard icon indicating copy to clipboard operation
parse-dashboard copied to clipboard

App name doesn't allow `@` symbol

Open markuswinkler opened this issue 4 years ago • 4 comments

New Issue Checklist

Issue Description

Jobs/Logs/API Console doesn't work. Just redirects back immediately to _Roles

Steps to reproduce

Click on Jobs/Logs or API Console

Actual Outcome

Redirect to the first class (_Role)

Expected Outcome

List of jobs

Environment

Dashboard

  • Parse Dashboard version: 3.2.1
  • Browser (Safari, Chrome, Firefox, Edge, etc.): Chrome
  • Browser version: 96.0

Server

  • Parse Server version: 4.10.4
  • Operating system: MacOS
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): local

Database

  • System (MongoDB or Postgres): MongoDB
  • Database version: 4.4.10
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): local

Logs

markuswinkler avatar Dec 18 '21 22:12 markuswinkler

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

I could not reproduce this issue with version Parse Dashboard 3.2.1. Could you post a screen recording to better understand what you observe?

mtrezza avatar Dec 19 '21 12:12 mtrezza

I managed to track it down, wasn't obvious. Problem was I used an app name that contained an "@". Easy to reproduce, just use this config file for parse-dashboard:

{
"apps": [
    {
      "serverURL": "http://localhost:1337/parse",
      "appId": "xxxxxxxxxx",
      "masterKey": "yyyyyyyyyy",
      "appName": "Foo@Foo",
	  "production": false,
	  "supportedPushLocales": ["en", "de"]
    }
  ]
}

Everything will work, except jobs and logs.

markuswinkler avatar Dec 19 '21 23:12 markuswinkler

I couldn't find any documented restrictions regarding the appName value. Since it's only a representational name, I would say that a @ should be allowed, as should be any unicode characters like for example emojis or non-latin characters such as Chinese glyphs (I would say also Arabic but I don't think the dashboard currently has RTL support).

mtrezza avatar Dec 21 '21 00:12 mtrezza