parse-dashboard icon indicating copy to clipboard operation
parse-dashboard copied to clipboard

refactor: upgrade React Router to v6

Open damianstasik opened this issue 2 years ago • 3 comments

New Pull Request Checklist

  • [x] I am not disclosing a vulnerability.
  • [x] I am creating this PR in reference to an issue.

Issue Description

Related issue: #1902

Approach

TODOs before merging

  • [ ] Add tests
  • [ ] Add changes to documentation (guides, repository pages, in-code descriptions)
  • [x] A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

damianstasik avatar Dec 09 '21 22:12 damianstasik

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

Damian, would you be available for a chat on Slack?

mtrezza avatar May 09 '22 11:05 mtrezza

@mtrezza yes, sure! You can reach me at <REMOVED>

damianstasik avatar May 23 '22 19:05 damianstasik

@visualfanatic What is the state of this PR? Are you actively working on it?

mtrezza avatar Sep 25 '22 11:09 mtrezza

@mtrezza I checked changes on alpha since my last update here and it looks like I don't have to adjust. Now I am going through each file making sure everything works as expected, and then I think it could be ready to be reviewed.

damianstasik avatar Sep 25 '22 11:09 damianstasik

Amazing, this will be a great merge!

mtrezza avatar Sep 25 '22 15:09 mtrezza

@mtrezza what should we do about failing CI due to minimum Node version required by React Router 6?

damianstasik avatar Sep 25 '22 15:09 damianstasik

@mtrezza I saw that there was an issue to remove Node 12 support, so I quickly did that to unblock this PR with updated router: https://github.com/parse-community/parse-dashboard/pull/2277

damianstasik avatar Sep 25 '22 16:09 damianstasik

@damianstasik Is his ready for review? If so, please request from dashboard-review team.

mtrezza avatar Sep 27 '22 22:09 mtrezza

🎉 This change has been released in version 5.0.0-alpha.4

parseplatformorg avatar Oct 09 '22 16:10 parseplatformorg

🎉 This change has been released in version 5.0.0-beta.1

parseplatformorg avatar Oct 17 '22 17:10 parseplatformorg

🎉 This change has been released in version 5.0.0

parseplatformorg avatar Nov 01 '22 20:11 parseplatformorg