parse-dashboard icon indicating copy to clipboard operation
parse-dashboard copied to clipboard

refactor: upgrade CI deps, bump Node.js version to 14

Open damianstasik opened this issue 2 years ago • 3 comments

New Pull Request Checklist

  • [x] I am not disclosing a vulnerability.
  • [x] I am creating this PR in reference to an issue.

Issue Description

This PR upgrades CI dependencies, but also bumps the minimum version of Node to 14 since semantic-release minimum Node version is 14.17.0. It would be also good for the dashboard to require Node 14 as Node 12 will reach end-of-life is on 2022-04-30.

Related issue: #1902

Approach

TODOs before merging

  • [x] A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

damianstasik avatar Dec 05 '21 20:12 damianstasik

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza semantic-release requires Node v14, should we ignore the update or bump our Node version to match it?

damianstasik avatar Dec 09 '21 22:12 damianstasik

... bumps the minimum version of Node to 14 since semantic-release minimum Node version is 14.17.0.

A dev dependency min node version should not determine the product's min node version. Dev dependencies are not used in the final product, unless maybe dev dependencies for testing. It's possible that the "Node engine check" also considers dev dependencies, which it should not. If there is no good reason to upgrade semantic release to a version that requires Node 14, we don't have to do it. In April next year we'll drop Node 12 support anyway, then we can also upgrade semantic release.

It would be also good for the dashboard to require Node 14 as Node 12 will reach end-of-life is on 2022-04-30

The dashboard repo does not have a compatibility table, but if you look at the one for Parse Server, you can see that we support a Node version until the end of its LTS date. I opened https://github.com/parse-community/parse-dashboard/issues/1956 for that.

mtrezza avatar Dec 10 '21 12:12 mtrezza