parse-dashboard icon indicating copy to clipboard operation
parse-dashboard copied to clipboard

refactor: upgrade linting deps

Open damianstasik opened this issue 2 years ago • 2 comments

New Pull Request Checklist

  • [x] I am not disclosing a vulnerability.
  • [x] I am creating this PR in reference to an issue.

Issue Description

  • This PR replaces deprecated babel-eslint with @babel/eslint-parser and updates ESLint deps.
  • I ran the lint script and fixed simple issues, but there is one issue not related to this PR in src/dashboard/Data/Browser/Browser.react.js@464 which should be addressed in a separate issue.
  • I also removed experimentalObjectRestSpread and jsx flags from ESLint config as they are not needed, jsx: true is set by the React plugin and experimentalObjectRestSpread is no longer experimental.
  • root: true is needed, so that Babel ESLint parser knows how to locate the babel config...
  • ...which I extracted to a separate file so that both webpack and ESLint share the Babel same config
  • This PR also upgrades all Babel deps to avoid installing older version of @babel/eslint-parser that was compatible with older deps.

Related issue: #1902

Approach

TODOs before merging

  • [x] A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

damianstasik avatar Dec 05 '21 20:12 damianstasik

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

Could you take a look at the failing test so can merge this?

mtrezza avatar May 29 '22 22:05 mtrezza

Could you take a look at at the conflict? I tried to resolve it manually, but the CI started to fail, so I reverted.

mtrezza avatar Oct 01 '22 19:10 mtrezza

🎉 This change has been released in version 5.0.0-alpha.4

parseplatformorg avatar Oct 09 '22 16:10 parseplatformorg

🎉 This change has been released in version 5.0.0-beta.1

parseplatformorg avatar Oct 17 '22 17:10 parseplatformorg

🎉 This change has been released in version 5.0.0

parseplatformorg avatar Nov 01 '22 20:11 parseplatformorg