parse-dashboard
parse-dashboard copied to clipboard
ci: fix lint and add husky hook
New Pull Request Checklist
- [x] I am not disclosing a vulnerability.
- [x] I am creating this PR in reference to an issue.
Issue Description
Makes a number of improvements to Lint.
Adds indentation rules, no code changes.
Related issue: #1783
Approach
Add pre-commit hook, fixes existing lint rules.
TODOs before merging
- [x] Add tests
- [x] Add entry to changelog
- [x] Add changes to documentation (guides, repository pages, in-code descriptions)
Thanks for opening this pull request!
- 🎉 We are excited about your hands-on contribution!
I would also like to add prettier but wanted to keep this PR minimal
Also related to #1789
Should we merge this now or wait until we have a few more PRs merged; this may need that authors refactor their PRs.
Your call! It's all auto-fixed anyway so it can wait
Then I'd say let's merge a few more larger PRs first
@dblythy I think after merging https://github.com/parse-community/parse-dashboard/pull/1657 this PR should be good to go, we have merged all other larger PRs since Sept 10. The other larger PRs (https://github.com/parse-community/parse-dashboard/pull/1677, https://github.com/parse-community/parse-dashboard/pull/1761) have become stale and it doesn't seem as if they'd be picked up anytime soon unfortunately.
I would still want us to consider whether we need enforcing pre-commit hooks, I personally am not in favor of these for reasons I have mentioned before.