parse-dashboard icon indicating copy to clipboard operation
parse-dashboard copied to clipboard

ci: fix lint and add husky hook

Open dblythy opened this issue 3 years ago • 7 comments

New Pull Request Checklist

  • [x] I am not disclosing a vulnerability.
  • [x] I am creating this PR in reference to an issue.

Issue Description

Makes a number of improvements to Lint.

Adds indentation rules, no code changes.

Related issue: #1783

Approach

Add pre-commit hook, fixes existing lint rules.

TODOs before merging

  • [x] Add tests
  • [x] Add entry to changelog
  • [x] Add changes to documentation (guides, repository pages, in-code descriptions)

dblythy avatar Sep 08 '21 23:09 dblythy

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

I would also like to add prettier but wanted to keep this PR minimal

dblythy avatar Sep 09 '21 00:09 dblythy

Also related to #1789

dblythy avatar Sep 09 '21 00:09 dblythy

Should we merge this now or wait until we have a few more PRs merged; this may need that authors refactor their PRs.

mtrezza avatar Sep 10 '21 01:09 mtrezza

Your call! It's all auto-fixed anyway so it can wait

dblythy avatar Sep 10 '21 01:09 dblythy

Then I'd say let's merge a few more larger PRs first

mtrezza avatar Sep 10 '21 01:09 mtrezza

@dblythy I think after merging https://github.com/parse-community/parse-dashboard/pull/1657 this PR should be good to go, we have merged all other larger PRs since Sept 10. The other larger PRs (https://github.com/parse-community/parse-dashboard/pull/1677, https://github.com/parse-community/parse-dashboard/pull/1761) have become stale and it doesn't seem as if they'd be picked up anytime soon unfortunately.

I would still want us to consider whether we need enforcing pre-commit hooks, I personally am not in favor of these for reasons I have mentioned before.

mtrezza avatar Oct 20 '21 14:10 mtrezza