parse-dashboard icon indicating copy to clipboard operation
parse-dashboard copied to clipboard

refactor: remove warnings by upgrading dependencies

Open romanbsd opened this issue 4 years ago • 5 comments

New Pull Request Checklist

  • [ x] I am not disclosing a vulnerability.
  • [ x] I am creating this PR in reference to an issue.

Issue Description

Update code to the current versions of 3rd party dependencies and standards. Related issue: #1679

Approach

Following current React practices

TODOs before merging

  • [x] Add tests
  • [x] Add entry to changelog
  • [x] Add changes to documentation (guides, repository pages, in-code descriptions)

romanbsd avatar Aug 19 '21 20:08 romanbsd

Thanks for opening this PR!

I think we discussed this already somewhere, but switching to yarn is something we would need to look at, because of potential CI implications and cross-repo compatibility (we don't use it anywhere else to my knowledge). Maybe to break this down into smaller packages, I would stick with npm for the time being and discuss a potential move to yarn in a separate issue.

mtrezza avatar Aug 24 '21 10:08 mtrezza

I can probably switch back to npm. There was some problem which I think was resolved since then.

romanbsd avatar Aug 24 '21 12:08 romanbsd

That would be good.

mtrezza avatar Aug 24 '21 13:08 mtrezza

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@romanbsd There are a bunch of conflicts here, would you want to switch from yarn to npm and resolve these? Then I would take care of testing the dashboard.

mtrezza avatar Sep 19 '21 13:09 mtrezza