parse-dashboard
parse-dashboard copied to clipboard
parse-community
feat: add custom branding with icon, brand name and color
parse-dashboard-config.json is improved with this options:
...
"customBrandIcon": "scanshop-logo-transparent.svg",
"customBrandTitle": "ScanShop Dashboard",
"customBrandColorPrimary": "#00A0FF",
...
NOTE: favicon and HTML title are on purpose kept unchanged and background color inside of React app.
This is initial version of custom branding, any more advanced custom branding could be implemented in another PR.
From default sidebar
to branded sidebar
From default login form
to branded login form
Danger run resulted in 1 warning; to find out more, see the checks page.
Generated by :no_entry_sign: dangerJS
@stepanic Thanks for this PR! And apologies that it didn't get much review attention anymore. We are on a spree now to close all open PRs. Could you rebase this on master and resolve any merge conflicts? It would be amazing if we could get this merged!
@stepanic Thanks for this PR! And apologies that it didn't get much review attention anymore. We are on a spree now to close all open PRs. Could you rebase this on master and resolve any merge conflicts? It would be amazing if we could get this merged!
@mtrezza conflict was resolved.
That was amazingly fast! I'll review this feature, @404-html do you maybe have any input in the meantime?
Nothing new from me, thanks for asking. I left some suggestions back in the day but nothing urgent 👍
Great! Could you look through the suggestions and see which ones you would mark as resolved? It seems most have been addressed.
@404-html I see that you left suggestions on 2021-05-19, which are only README related will you commit them and then integrate this PR?
Sorry @stepanic, looks like I don't have permission:
Also, I can't see an option to resolve those. Is there any "Apply" button next to my suggestions? If not I think we can skip them, they are minor.
@404-html This may be if you had write access at some point. We have recently changes our permission model and are limiting write permissions to reviewers to are active on a regular basis, for security reasons, because the write permissions are quite wide-ranging.
@stepanic Could you incorporate the change suggestions and resolve the conversations that have been addressed? Then we can easily see whether there are any open questions. I'm preparing a release, so it would be great to get this feature in there.
@stepanic There have been some merges on master, could you please rebase/merge and then request a review?
@mtrezza merged with master without conflicts :D
$ git merge upstream/master
Auto-merging src/components/LoginForm/LoginForm.react.js
Removing server.js
Auto-merging README.md
Merge made by the 'recursive' strategy.
.github/workflows/ci.yml | 169 +++-
.github/workflows/docker-publish.yml | 62 ++
CHANGELOG.md | 8 +
Dockerfile | 4 +-
Parse-Dashboard/Authentication.js | 34 +-
Parse-Dashboard/CLI/mfa.js | 225 +++++
Parse-Dashboard/CLI/utils.js | 7 +
Parse-Dashboard/CLIHelper.js | 6 +
Parse-Dashboard/index.js | 11 +
README.md | 43 +-
ci/CiVersionCheck.js | 290 ++++++
ci/ciCheck.js | 36 +
ci/nodeEngineCheck.js | 187 ++++
package-lock.json | 5489 +++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------------------
package.json | 22 +-
server.js | 19 -
src/components/LoginForm/LoginForm.react.js | 1 +
src/dashboard/Dashboard.js | 2 +
src/lib/stores/SchemaStore.js | 4 +-
src/login/Login.js | 39 +-
20 files changed, 3332 insertions(+), 3326 deletions(-)
create mode 100644 .github/workflows/docker-publish.yml
create mode 100644 Parse-Dashboard/CLI/mfa.js
create mode 100644 Parse-Dashboard/CLI/utils.js
create mode 100644 Parse-Dashboard/CLIHelper.js
create mode 100644 ci/CiVersionCheck.js
create mode 100644 ci/ciCheck.js
create mode 100644 ci/nodeEngineCheck.js
delete mode 100755 server.js
@stepanic Could you please merge master into this? It again became out-of-date with the base branch. I'll make sure to review this next, so you don't have to do this again.
@stepanic If you have some time, it would be great if you could look over the feedback above, so we can merge this PR.
@visualfanatic If you are interested in completing this PR, I think there is not much missing. The feature now has a bounty applied to it since the PR has become stale.
@andreafalzetti Feel free to pick it up if you like, it seems to be almost done.