node-apn
node-apn copied to clipboard
fix: Incorrect key `events` instead of `event` for Live Activity
Continuing from here.
This reverts this PR from @dplewis.
Additionally it adds dismissal-date
as a field to APS + tests.
Thanks for opening this pull request!
- ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as
Closes: #123
in the PR description, so I can recognize it.
I will reformat the title to use the proper commit message syntax.
This is 2 PRs (feature addition + bug fix) in 1. Could you please separate the dismissal date addition into a separate PR? Unless it's related to the bug fix of course.
@kurtguenther Do you think you could move the feature addition into a separate PR, so we can get this bug fix merged? It also seems that the feature tests are not passing in the CI.
Superseded by https://github.com/parse-community/node-apn/pull/148