node-apn icon indicating copy to clipboard operation
node-apn copied to clipboard

[Snyk] Security upgrade jsonwebtoken from 8.5.1 to 9.0.0

Open parseplatformorg opened this issue 2 years ago • 7 comments

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 671/1000
Why? Recently disclosed, Has a fix available, CVSS 7.7
Improper Input Validation
SNYK-JS-JSONWEBTOKEN-3180020
Yes No Known Exploit
medium severity 611/1000
Why? Recently disclosed, Has a fix available, CVSS 6.5
Improper Authentication
SNYK-JS-JSONWEBTOKEN-3180022
Yes No Known Exploit
medium severity 611/1000
Why? Recently disclosed, Has a fix available, CVSS 6.5
Improper Restriction of Security Token Assignment
SNYK-JS-JSONWEBTOKEN-3180024
Yes No Known Exploit
medium severity 526/1000
Why? Recently disclosed, Has a fix available, CVSS 4.8
Use of a Broken or Risky Cryptographic Algorithm
SNYK-JS-JSONWEBTOKEN-3180026
Yes No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: jsonwebtoken The new version differs by 17 commits.
  • e1fa9dc Merge pull request from GHSA-8cf7-32gw-wr33
  • 5eaedbf chore(ci): remove github test actions job (#861)
  • cd4163e chore(ci): configure Github Actions jobs for Tests & Security Scanning (#856)
  • ecdf6cc fix!: Prevent accidental use of insecure key sizes & misconfiguration of secrets (#852)
  • 8345030 fix(sign&verify)!: Remove default `none` support from `sign` and `verify` methods, and require it to be explicitly configured (#851)
  • 7e6a86b Upload OpsLevel YAML (#849)
  • 74d5719 docs: update references vercel/ms references (#770)
  • d71e383 docs: document "invalid token" error
  • 3765003 docs: fix spelling in README.md: Peak -> Peek (#754)
  • a46097e docs: make decode impossible to discover before verify
  • 15a1bc4 refactor: make decode non-enumerable
  • 5f10bf9 docs: add jwtid to options of jwt.verify (#704)
  • 88cb9df Replace tilde-indexOf with includes (#647)
  • a6235fa Adds not to README on decoded payload validation (#646)
  • 5ed1f06 docs: fix tiny style change in readme (#622)
  • 9fb90ca style: add missing semicolon (#641)
  • a9e38b8 ci: use circleci (#589)

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information: 🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Use of a Broken or Risky Cryptographic Algorithm

parseplatformorg avatar Dec 22 '22 23:12 parseplatformorg

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

Codecov Report

Base: 93.42% // Head: 93.42% // No change to project coverage :thumbsup:

Coverage data is based on head (c5a21a6) compared to base (650993d). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files          23       23           
  Lines         578      578           
=======================================
  Hits          540      540           
  Misses         38       38           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Dec 22 '22 23:12 codecov[bot]

When can we expect these fixes because [email protected] as high vulnerable and I hope fixes also ready. It will be helpful if you guys release these fixes asap.

VulchiSarath avatar Jan 23 '23 09:01 VulchiSarath

It would be very helpful if this could be fixed

ldikmans avatar Feb 18 '23 16:02 ldikmans

@mtrezza do you know if anyone is still maintaining this library? This library is also used in node-pushnotifications, see package.json

This security upgrade would be very helpful. Thanks for your reply!

ldikmans avatar Mar 13 '23 15:03 ldikmans

Our fork contains a few changes that are partly also merged in the original repository. The current intention is to compare the 2, bring the original repo up-to-date (if needed at all), then archive our fork and use the original repo instead. There have been similar PRs merged on both and releases published on both, so this take a bit more effort.

mtrezza avatar Mar 14 '23 23:03 mtrezza

Our fork contains a few changes that are partly also merged in the original repository. The current intention is to compare the 2, bring the original repo up-to-date (if needed at all), then archive our fork and use the original repo instead. There have been similar PRs merged on both and releases published on both, so this take a bit more effort.

Would it be possible to merge the fix in the mean time?

ldikmans avatar Jul 13 '23 09:07 ldikmans