docs icon indicating copy to clipboard operation
docs copied to clipboard

Docs for CLP Pointer permissions.

Open BufferUnderflower opened this issue 5 years ago • 8 comments

parse-community/parse-server#6351 parse-community/parse-server#6352

BufferUnderflower avatar Jan 17 '20 01:01 BufferUnderflower

Wow, this is quite substantial, reviewing this is on my to-do list now that the parse server pr has been merged but this won’t be merged until the next release.

TomWFox avatar Jan 28 '20 22:01 TomWFox

@BufferUnderflower If you've got maintainer commits turned on I could commit these suggestions and others myself. Otherwise could you look over my review? - there is going to be a Parse Server release soon so I'd like to get this ready to go.

TomWFox avatar Feb 16 '20 22:02 TomWFox

A note on protected fields. It's probably too early to disclose the documentation, since it's pretty far for being production ready. I'm now working on some tests to show what's left to be done there. Main concerns:

  • We don't cover create/update operations, and they're pretty complicated to handle.
  • As of now protection is not always enforced.

BufferUnderflower avatar Mar 01 '20 13:03 BufferUnderflower

Ok, thanks for that info.

Perhaps if it's not too difficult you could remove the content about protected fields from this PR and make a separate draft PR for when its more production ready or do you want to hold back this whole PR until those issues have been addressed on parse server?

TomWFox avatar Mar 01 '20 13:03 TomWFox

There is no need to hold CLP, in fact it would be nice to finish it asap and merge, because protected fields would require lots of love before being ready i'm afraid.

BufferUnderflower avatar Mar 01 '20 14:03 BufferUnderflower

Probably it would be wise to publish some warning in docs against use for sensitive data temporarily, since it appears in 4.0 changelog and there were several issues by folks interested in it.

BufferUnderflower avatar Mar 01 '20 14:03 BufferUnderflower

If your right about the issues with protected fields I would absolutely agree that warnings should be given. Feel free to open an issue/pr on parse server for that.

TomWFox avatar Mar 01 '20 16:03 TomWFox

@BufferUnderflower Sorry this has been neglected, a final review of this is on my to-do list!

TomWFox avatar Apr 08 '20 21:04 TomWFox