ParseLiveQuery-iOS-OSX icon indicating copy to clipboard operation
ParseLiveQuery-iOS-OSX copied to clipboard

ci: fix CircleCI carthage timeout

Open mtrezza opened this issue 3 years ago • 8 comments

New Pull Request Checklist

  • [x] I am not disclosing a vulnerability.
  • [x] I am creating this PR in reference to an issue.

Issue Description

Related issue: https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1656

Approach

Increase timeout.

TODOs before merging

n/a

mtrezza avatar Jul 27 '22 12:07 mtrezza

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@drdaz Strangely, here the timeout increase did not help, Carthage keep failing after ~16mins. Any idea?

mtrezza avatar Jul 28 '22 20:07 mtrezza

@mtrezza Not without seeing the test logs I'm afraid. It should be possible to run the target enabling SSH access, then you should be able to see how it's failing. The location of the logs is provided in the test failure console output.

drdaz avatar Aug 02 '22 13:08 drdaz

Oh now I see it 😅

Carthage seems to be importing v6.x of the Facebook SDK. The main repo uses 11.x (which is also pretty behind the times), and contains breaking changes.

drdaz avatar Aug 02 '22 13:08 drdaz

Got it, do you think upgrading the FB SDK would be a time consuming PR?

mtrezza avatar Aug 03 '22 19:08 mtrezza

I feel like maybe another PR would be overkill. I'm pretty sure if you run carthage update on here and commit the changes to Cartfile.resolved (not all the stuff it checks out and builds), it'll work.

I tried to push those changes to this branch, but I'm getting an authentication error. Not sure if that's on my end or if I don't have push-powers here.

drdaz avatar Aug 05 '22 12:08 drdaz

or if I don't have push-powers here

I think only the author and repo maintainers can push to a PR as the settings currently are.

mtrezza avatar Aug 05 '22 20:08 mtrezza

carthage update failed for me on arm64 with:

Building universal frameworks with common architectures is not possible. The device and simulator slices for "Bolts" both build for: arm64
Rebuild with --use-xcframeworks to create an xcframework bundle instead.

mtrezza avatar Aug 05 '22 21:08 mtrezza