Parse-Swift icon indicating copy to clipboard operation
Parse-Swift copied to clipboard

feat: add access group and keychain synchronization

Open cbaker6 opened this issue 3 years ago • 2 comments

New Pull Request Checklist

  • [x] I am not disclosing a vulnerability.
  • [x] I am creating this PR in reference to an issue.

Issue Description

Items in keychain currently can't be synced across apps or groups.

Related issue: #n/a

Approach

Follow: https://developer.apple.com/documentation/security/keychain_services/keychain_items/sharing_access_to_keychain_items_among_a_collection_of_apps

TODOs before merging

  • [ ] Add tests
  • [ ] Add entry to changelog
  • [x] Add changes to documentation (guides, repository pages, in-code descriptions)

cbaker6 avatar Jul 03 '22 21:07 cbaker6

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

Codecov Report

Merging #378 (b530234) into main (89e5e69) will increase coverage by 0.23%. The diff coverage is 98.90%.

@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   89.06%   89.29%   +0.23%     
==========================================
  Files         156      157       +1     
  Lines       14778    14970     +192     
==========================================
+ Hits        13162    13368     +206     
+ Misses       1616     1602      -14     
Impacted Files Coverage Δ
Sources/ParseSwift/Storage/ParseStorage.swift 82.14% <ø> (ø)
Sources/ParseSwift/Types/ParseACL.swift 93.58% <ø> (ø)
Sources/ParseSwift/Storage/KeychainStore.swift 97.86% <98.40%> (+2.21%) :arrow_up:
Sources/ParseSwift/Objects/ParseInstallation.swift 85.27% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseObject.swift 87.29% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseUser.swift 86.34% <100.00%> (+0.19%) :arrow_up:
Sources/ParseSwift/Parse.swift 91.28% <100.00%> (+2.61%) :arrow_up:
...es/ParseSwift/Protocols/ParseHookRequestable.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/Types/ParseConfig.swift 100.00% <100.00%> (+1.09%) :arrow_up:
...es/ParseSwift/Types/ParseKeychainAccessGroup.swift 100.00% <100.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 03 '22 21:07 codecov[bot]