Parse-SDK-iOS-OSX icon indicating copy to clipboard operation
Parse-SDK-iOS-OSX copied to clipboard

SSL Certificate Pinning delegate

Open gytiskv opened this issue 4 years ago • 4 comments

This adds a PFUrlSessionChallengeDelegate to Parse Configuration.

Note: Docs and description will be added soon.

gytiskv avatar Jan 25 '21 11:01 gytiskv

Hey guys, is there anything I can do to help get this PR merged? Quite eager to implement certificate pinning in my iOS app.

magneticrob avatar Feb 05 '21 10:02 magneticrob

@magneticrob thanks for chiming in, really the main block right now is a review from a maintainer. I can't do that at the moment.

If you could review this yourself and/or test it out in your own app that would be helpful but I can't say it will be merged immediately after that.

In the meantime though, you could use @gytiskv's fork in your app.

TomWFox avatar Feb 10 '21 23:02 TomWFox

Thanks for submitting this.

Is there any way we can get your changes against current master? There's some odd stuff going on with version numbers, and I'm not sure why; I suspect it's to do with the basing of your branch. Certainly, we don't want to be downgrading Swift version and a bunch of dependencies.

There don't appear to be automated tests for the new functionality. We’ll need those.

I haven't opened the project in Xcode, but looking at the changes there appears to be a new tester app? What’s going on there?

drdaz avatar May 27 '21 16:05 drdaz

This issue has been automatically marked as stale because it has not had recent activity. If you believe it should stay open, please let us know! As always, we encourage contributions, check out the Contributing Guide

stale[bot] avatar Jul 13 '21 02:07 stale[bot]

Closing as it seems stale and requires an extensive rebase on the master branch.

mtrezza avatar Oct 24 '23 13:10 mtrezza