Parse-SDK-JS icon indicating copy to clipboard operation
Parse-SDK-JS copied to clipboard

Many repeated health requests if a server return an error in response

Open igor-lemon opened this issue 4 years ago • 6 comments

New Issue Checklist

Issue Description

If backend return 4xx or 5xx error to /health request SDK makes many repeated /health requests per second endless.

Steps to reproduce

Return to the health request 400 or 500 error.

Actual Outcome

SDK makes many repeated requests per second

Expected Outcome

Should make next health request in 2 seconds

image

igor-lemon avatar Oct 18 '21 09:10 igor-lemon

Thanks for opening this issue!

  • ❌ Please edit your post and use the provided template when creating a new issue. This helps everyone to understand your post better and asks for essential information to quicker review the issue.

Could you rephrase the issue description? I am not sure how to understand it. Do you mean that a 4xx or 5xx response from the server triggers many repeated requests to the health endpoint from the SDK?

mtrezza avatar Oct 18 '21 10:10 mtrezza

If a HTTP server return 400 or 500 code to /health request SDK start spam /health requests many times without any delay, ~4-6 requests per seconds endless

igor-lemon avatar Oct 18 '21 10:10 igor-lemon

Can you reproduce this in a PR with a test?

mtrezza avatar Oct 18 '21 12:10 mtrezza

nope

igor-lemon avatar Oct 18 '21 17:10 igor-lemon

Can you add the steps to reproduce this somehow?

mtrezza avatar Oct 18 '21 18:10 mtrezza

@mtrezza this was fixed via https://github.com/parse-community/Parse-SDK-JS/pull/1419

dplewis avatar Nov 09 '22 18:11 dplewis

Was this a Parse Server issue or a Parse JS SDK issue? If so, I'll move the issue to the JS SDK.

mtrezza avatar Nov 09 '22 18:11 mtrezza

This is the JS SDK that the issue was posted in, no need to move it

dplewis avatar Nov 09 '22 19:11 dplewis

Closed via https://github.com/parse-community/Parse-SDK-JS/pull/1419

mtrezza avatar Nov 09 '22 19:11 mtrezza