Parse-SDK-JS icon indicating copy to clipboard operation
Parse-SDK-JS copied to clipboard

Improved Auth Spec & challenge endpoint

Open Moumouls opened this issue 4 years ago • 9 comments

Need: https://github.com/parse-community/Parse-SDK-JS/pull/1275

SDK Login update for: https://github.com/parse-community/parse-server

Note: On OSX can test integration with 3.6, and tests fails in mongo 4.0 due to invalid field name "length"

If CI pass then we have detected a regression between mongo 3.6 and 4.0 for field name length on objects

  • [x] Challenge mehod

Moumouls avatar Dec 11 '20 12:12 Moumouls

Warnings
:warning: Please add a changelog entry for your changes.

Generated by :no_entry_sign: dangerJS

ghost avatar Dec 11 '20 12:12 ghost

Codecov Report

Merging #1276 (c787972) into master (4a75d97) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head c787972 differs from pull request most recent head a31beb6. Consider uploading reports for the commit a31beb6 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1276   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          60       60           
  Lines        5847     5869   +22     
  Branches     1311     1320    +9     
=======================================
+ Hits         5844     5866   +22     
  Misses          3        3           
Impacted Files Coverage Δ
src/ParseUser.js 99.59% <100.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a75d97...a31beb6. Read the comment docs.

codecov[bot] avatar Dec 11 '20 12:12 codecov[bot]

Issue reported for Mongo 4.X and field name length: https://github.com/parse-community/Parse-SDK-JS/issues/1277

Moumouls avatar Dec 11 '20 12:12 Moumouls

@dplewis if you have an idea on the failing integration test, npm run integration is okay on my side, may be a Github CI cache issue ?

Moumouls avatar Dec 15 '20 11:12 Moumouls

@Moumouls Can you update from master?

dplewis avatar Jan 18 '21 17:01 dplewis

@dplewis if you have some suggestion about the failing test ? 🙂

Moumouls avatar Apr 09 '21 07:04 Moumouls

Can you update from master again? The new release removes the flaky tests.

dplewis avatar Apr 09 '21 15:04 dplewis

Done @dplewis

Moumouls avatar Apr 09 '21 17:04 Moumouls

@Moumouls how is this coming along? Would be good to have implemented for Parse Server 6

dblythy avatar Jan 04 '23 00:01 dblythy