fix: some parameters of `ParseLiveGridWidget` are not used
New Pull Request Checklist
- [x] I am not disclosing a vulnerability.
- [x] I am creating this PR in reference to an issue.
Issue Description
Implementation of Scroll Direction and other other parameters/attributes
Related issue: #760
Approach
TODOs before merging
n/a
- [ ] Add tests
- [ ] Add changes to documentation (guides, repository pages, in-code descriptions)
- [ ] A changelog entry
Thanks for opening this pull request!
- ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as
Closes: #123in the PR description, so I can recognize it.
Codecov Report
Patch coverage has no change and project coverage change: -0.08 :warning:
Comparison is base (
366f2dd) 39.11% compared to head (85dc209) 39.04%.
Additional details and impacted files
@@ Coverage Diff @@
## master #761 +/- ##
==========================================
- Coverage 39.11% 39.04% -0.08%
==========================================
Files 57 57
Lines 3280 3286 +6
==========================================
Hits 1283 1283
- Misses 1997 2003 +6
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...ackages/flutter/lib/src/utils/parse_live_grid.dart | 0.00% <0.00%> (ø) |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Is this a bug fix or a feature extension?
It's a mix, I guess. Maybe more of a bug fix, since the parameters already exist and are just not used (bug).
Does this PR require any tests or doc changes? @pastordee could you please go through the TODOs at the top?
sorry guys is a bug fix some of the parameters are not used
Does this PR require any tests or doc changes? @pastordee could you please go through the TODOs at the top?
no it doesn't need a test
If it takes too much research to add tests for this since we don't test widgets yet at all, then we can merge just to fix the bug. But we will at some point begin to make tests a requirement for merging a PR. Otherwise - by experience - these tests are unlikely to be added in the future and coverage will continue to decrease.
@fischerscode You already approved this PR, but note that it's missing a changelog entry, that is a hard requirement for PRs already.
it's missing a changelog entry
Sorry, thought we want to create it automatically for the next release.
Sorry, thought we want to create it automatically for the next release.
I wish! But I think it will take some time to add auto-release to this mono repo.
Sorry, thought we want to create it automatically for the next release.
I wish! But I think it will take some time to add auto-release to this mono repo.
added to the change log
Sorry, thought we want to create it automatically for the next release.
I wish! But I think it will take some time to add auto-release to this mono repo.
Hi can we approve and merge this please.
- flutter version need to be bumped for a new release
- dart dependency in flutter package needs to be bumped (?)
- changelog needs to be updated (version, date)
- maybe PR title can be more descriptive, so developers who read the changelog know better what this fix is about
I will reformat the title to use the proper commit message syntax.
This PR will be released as flutter version 3.1.4; to merge this, the flutter package version needs to be updated as well.
Hey please when will this be released?
See https://github.com/parse-community/Parse-SDK-Flutter/pull/761#issuecomment-1362012377
I think before we can merge this we should fix https://github.com/parse-community/Parse-SDK-Flutter/issues/835
I think I came late to this PR because there are 31 comments and only 6 lines changed. Is there anything I should know?
Could you please add a changelog entry and bump the version?
Okay, will do as soon as I get home
@pastordee Please, if possible, add entries based on the latest version
This PR is long overdue!
Done
@pastordee It seems that you have a conflict
This branch has conflicts that must be resolved
@pastordee It seems that you have a conflict
This branch has conflicts that must be resolved
Sorted
@pastordee I think you should bump the version