Parse-SDK-Android icon indicating copy to clipboard operation
Parse-SDK-Android copied to clipboard

Java 1.8 compile option unnecessary since Gradle 7

Open mobilekosmos opened this issue 3 years ago • 5 comments

New Feature / Enhancement Checklist

Following block in all build.gradle files is not needed anymore since using Gradle 7 because implicitly defined: compileOptions { sourceCompatibility JavaVersion.VERSION_1_8 targetCompatibility JavaVersion.VERSION_1_8 }

Can be removed.

mobilekosmos avatar Apr 16 '22 04:04 mobilekosmos

Do you want to open a PR for this?

Can you please add a reference link to an official resource that states the exact version since when Java 1.8 is used by default?

mtrezza avatar Apr 16 '22 04:04 mtrezza

Thanks for opening this issue!

  • ❌ Please edit your post and use the provided template when creating a new issue. This helps everyone to understand your post better and asks for essential information to quicker review the issue.

https://developer.android.com/studio/releases/gradle-plugin?hl=nl#java-8-default I also tried it in the past, before Gradle 7 you got a compiler error if I remember correctly if you didn't have that block in the gradle file, with Gradle 7 you don't get any error or warning when removing it.

mobilekosmos avatar Apr 16 '22 06:04 mobilekosmos

Is this only relevant for when compiling the Parse Android SDK, or also for developers who add the SDK as a dependency?

mtrezza avatar Apr 16 '22 10:04 mtrezza

@mtrezza it's mostly relevant for this SDK as we do not know which version the users will use. Most probably all users already uses Gradle 7 and latest Android toolchains.

azlekov avatar Apr 16 '22 11:04 azlekov