xpad icon indicating copy to clipboard operation
xpad copied to clipboard

Merging "support for xbox360 class controllers, that need initialisation" to upstream xpad

Open nondebug opened this issue 1 year ago • 2 comments

@Oblomov's PR #120 was merged 3 years ago and fixes a number of third-party Xbox 360 controllers, including Elecom JC-U4013SBK. It would be great to get these fixes upstreamed.

Is there a reason this can't be upstreamed? What needs to happen before it can be merged?

nondebug avatar Aug 09 '24 00:08 nondebug

FWIW the kernel driver seems to have some related changes that fix initialization of these controllers. I've been using the kernel driver instead of this module for a while now without issues.

Oblomov avatar Aug 09 '24 16:08 Oblomov

try changing this line to if(0): https://github.com/paroj/xpad/blob/c379818298e0e7477b4a070e219c81817412226c/xpad.c#L2008

and check whether your controller still works.

we currently send both init sequences to xpad360 controllers. What upstream does and what we did previously. I cannot verify which one is better, so I have to wait for reports.

paroj avatar Oct 18 '24 18:10 paroj