nasc icon indicating copy to clipboard operation
nasc copied to clipboard

Project fails to build with Git submodule

Open danirabbit opened this issue 2 years ago • 3 comments

Describe the bug

It looks like we're unable to build NaSC because it relies on a git submodule

To Reproduce https://github.com/elementary/appcenter-reviews/pull/77/checks?check_run_id=3403685174

Expected behavior Since Flatpak has a built-in concept of vendoring, it might be better to use modules in your Flatpak manifest instead.

We encountered a similar issue in another app and the developer decided to add a build option here: https://github.com/ryonakano/konbucase/pull/68/files

danirabbit avatar Aug 23 '21 19:08 danirabbit

I can build it with this without problems. https://github.com/parnold-x/nasc/blob/master/.github/workflows/main.yml#L17

Otherwise, no time right now to fiddle more with this flatpack stuff.

parnoldx avatar Aug 24 '21 21:08 parnoldx

It looks like the github builder doesn't have network access, so the cloning fails

ckruse avatar Sep 03 '21 06:09 ckruse

Is there any chance this could get looked at? I'd love NaSC to be available again on the AppCenter

ChildishGiant avatar Nov 30 '21 20:11 ChildishGiant