ctcdecode icon indicating copy to clipboard operation
ctcdecode copied to clipboard

Modification for adapting newer C++17 and Pytorch 2.0+

Open WayenVan opened this issue 1 year ago • 14 comments

For anyone who are struggling with installing this repo, I've forked and made some changes, which could successfully installed in Pytorch2.0+ with C++17.

Please check here https://github.com/WayenVan/ctcdecode

WayenVan avatar Jun 27 '24 01:06 WayenVan

That works for pytorch 2.3.0. Thank you so much!!!!

Basicname avatar Jul 08 '24 12:07 Basicname

ty so much. a big time saver!

hm-ca avatar Aug 30 '24 00:08 hm-ca

Thanks! @WayenVan

Hi @rbracco, can you kindly merge this to the original repo?

farisalasmary avatar Sep 11 '24 04:09 farisalasmary

Thanks! @WayenVan

Hi @rbracco, can you kindly merge this to the original repo?

Hi, sorry, I can not as I am not a maintainer of the repo, I just contributed to making the README more clear.

rbracco avatar Sep 11 '24 15:09 rbracco

@WayenVan could you explain what did you change to make it work on Pytorch2.0+?

ducanh841988 avatar Oct 28 '24 02:10 ducanh841988

For anyone who are struggling with installing this repo, I've forked and made some changes, which could successfully installed in Pytorch2.0+ with C++17.

Please check here https://github.com/WayenVan/ctcdecode

Thank You

pallapumohankrishna avatar Feb 21 '25 16:02 pallapumohankrishna

For anyone who are struggling with installing this repo, I've forked and made some changes, which could successfully installed in Pytorch2.0+ with C++17.

Please check here https://github.com/WayenVan/ctcdecode

Thank you, It worked.

stephenbernard26 avatar Apr 05 '25 09:04 stephenbernard26

  ctcdecode/src/ctc_beam_search_decoder.cpp:113:17: warning: comparison of integer expressions of different signedness: ‘long unsigned int’ and ‘int’ [-Wsign-compare]
    113 |           if (c == prefix->character &&
        |               ~~^~~~~~~~~~~~~~~~~~~~
  ctcdecode/src/ctc_beam_search_decoder.cpp:116:24: warning: comparison of integer expressions of different signedness: ‘long unsigned int’ and ‘int’ [-Wsign-compare]
    116 |           } else if (c != prefix->character) {
        |                      ~~^~~~~~~~~~~~~~~~~~~~
  ctcdecode/src/ctc_beam_search_decoder.cpp:122:18: warning: comparison of integer expressions of different signedness: ‘long unsigned int’ and ‘int’ [-Wsign-compare]
    122 |               (c == space_id || ext_scorer->is_character_based())) {
        |                ~~^~~~~~~~~~~
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip. ERROR: Failed building wheel for ctcdecode Running setup.py clean for ctcdecode Failed to build ctcdecode ERROR: Failed to build installable wheels for some pyproject.toml based projects (ctcdecode)

Hi, I have encountered the above problems and have been unable to solve them. Can you give me some help?

wumiaoshu avatar May 17 '25 10:05 wumiaoshu