zombienet icon indicating copy to clipboard operation
zombienet copied to clipboard

Add support for chain spec modifier commands

Open Fahrrader opened this issue 1 year ago • 7 comments

In response to https://github.com/paritytech/zombienet/issues/892.

Fahrrader avatar Apr 08 '23 21:04 Fahrrader

User @Fahrrader, please sign the CLA here.

cla-bot-2021[bot] avatar Apr 08 '23 21:04 cla-bot-2021[bot]

Tests (and examples and docs, probably) are required, but putting the draft out there for review :)

Fahrrader avatar Apr 08 '23 21:04 Fahrrader

@Fahrrader , also, please run lint prior to next push, for the checks to pass

wirednkod avatar Apr 10 '23 08:04 wirednkod

Docs, examples and tests (hopefully) are up and ready!

Fahrrader avatar Apr 19 '23 08:04 Fahrrader

@pepoviola @wirednkod I think this PR is good to go and ready for the final review! I believe all the previous concerns were addressed. Please take another look, if not already.

Fahrrader avatar Apr 25 '23 12:04 Fahrrader

Hi @Fahrrader, sorry about the delay. First let me say thanks for contribution and your feedback. We had discussed with the team and some security concerns arise from allow users to execute arbitrary 3rd party tools as part of the spawning process. We have a couple of options, we can built-in some kind of customization tool that allow us to have more control of what is executed, we can allow this execution (giving us more flexibility) and add some guards (like don't allow to run with root access) or we can also make the spawning process more flexible and add a command to just produce the chain artifacts so allow others tools to interact with zombienet to their needs.

I will a new discussion in the repo to collect some feedback before go into one of the paths. Agains, sorry about the delay and thanks for your contribution and feedback!!

pepoviola avatar May 12 '23 14:05 pepoviola

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/discover-chainql-unique-networks-advanced-tool-for-substrate-chain-storage/2861/1

Polkadot-Forum avatar May 15 '23 14:05 Polkadot-Forum