substrate icon indicating copy to clipboard operation
substrate copied to clipboard
verified publisher icon paritytech

rpc: backpressured RPC server (bump jsonrpsee 0.20)

Open niklasad1 opened this issue 2 years ago • 10 comments

This is rather big change but most stuff are "chore", the major things in this bump are:

  • Server backpressure (the subscription impls are modified to deal with that)
  • Allow custom error types / return types (remove jsonrpsee::core::Error and jsonrpee::core::CallError)
  • Easier subscription API (spawned internally by jsonrpsee doesn't work well with rpc subscription prometheus, so these are spawned with oneshot to keep it alive)
  • Bug fixes (graceful shutdown in particular not used by substrate anyway)
  • Less dependencies for the clients in particular
  • Return type requires Clone in method call responses
  • tokio channels are now used and tests must run on the tokio runtime to not panic

Hopefully the last release prior to 1.0, sorry in advance for a big PR

polkadot companion: https://github.com/paritytech/polkadot/pull/7211

cumulus companion: https://github.com/paritytech/cumulus/pull/2560

niklasad1 avatar Apr 24 '23 15:04 niklasad1

bot rebase

niklasad1 avatar May 11 '23 12:05 niklasad1

Rebased

paritytech-processbot[bot] avatar May 11 '23 12:05 paritytech-processbot[bot]

bot rebase

niklasad1 avatar May 12 '23 11:05 niklasad1

Rebased

paritytech-processbot[bot] avatar May 12 '23 11:05 paritytech-processbot[bot]

this is blocked on a pending burn-in

niklasad1 avatar May 17 '23 15:05 niklasad1

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 30 '23 21:07 stale[bot]

The CI pipeline was cancelled due to failure one of the required jobs. Job name: cargo-check-benches Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3295104

paritytech-cicd-pr avatar Jul 31 '23 08:07 paritytech-cicd-pr

The CI pipeline was cancelled due to failure one of the required jobs. Job name: cargo-check-benches Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3295105

paritytech-cicd-pr avatar Jul 31 '23 08:07 paritytech-cicd-pr

Sorry for walking in without context, yet what were the regressions identified preventing this from being merged?

kayabaNerve avatar Aug 23 '23 10:08 kayabaNerve

Sorry for walking in without context, yet what were the regressions identified preventing this from being merged?

A leak and that the new async subscription API allocates more memory.

The leak is now fixed but investigating a fix for the increased memory usage.

niklasad1 avatar Aug 23 '23 10:08 niklasad1