Create benchmark for the `system::set_code` instrisic

[hirschenberger]

Benchmark system::set_code by timing uncompression and setting the kitchensink runtime, which is a rather big runtime. So it should be feasible to determine an upper bound.

fixes #13192

[hirschenberger]

I don't really know how to fix the current compiler error in the verify function. Thankful for any hint.

[ggwpez]

You can use System::assert_last_event instead.

[hirschenberger]

It's hard to make the tests and benchmarks run without failure without too much conditional compilation

[hirschenberger]

@bkchr Is it ok to remove the verify arm from the benchmark to make it run without errors?

[bkchr]

@bkchr Is it ok to remove the verify arm from the benchmark to make it run without errors?

The benchmark test is failing because it misses an extension to be registered for the tests. @ggwpez can you show him how to register extensions for benchmark tests?

[stale[bot]]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

[hirschenberger]

It seems to require a companion PR

[hirschenberger]

The polkadot companion CI seems to hang :-(

[ggwpez]

bot bench $ pallet dev frame_system

[command-bot[bot]]

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2680053 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev frame_system. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-9279d82d-bc0c-4aba-bd64-d78675a00270 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot[bot]]

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev frame_system has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2680053 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2680053/artifacts/download.

[ggwpez]

bot fmt

[command-bot[bot]]

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2693079 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2693079/artifacts/download.

[bkchr]

/tip small

[substrate-tip-bot[bot]]

@bkchr Contributor did not properly post their account address.

Make sure the pull request description has: "{network} address: {address}".

[hirschenberger]

/tip small

I added my address

[bkchr]

bot fmt

[command-bot[bot]]

@bkchr https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2712428 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 49-88735a74-51d0-4eab-89ef-345d30ffe768 to cancel this command or bot cancel to cancel all commands in this pull request.

[bkchr]

/tip small

[substrate-tip-bot[bot]]

@bkchr A small tip was successfully submitted for hirschenberger (1ZApdbwrNnT1Hey4xeTAH6SZPDgbA9ZVftNuu9jTRbkc2Bg on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips

[command-bot[bot]]

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2712428 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2712428/artifacts/download.

[juangirini]

@hirschenberger the Cumulus companion seems to be missing

[ggwpez]

bot rebase

[paritytech-processbot[bot]]

Rebased

[ggwpez]

bot merge

[paritytech-processbot[bot]]

Error: "Check reviews" status is not passing for https://github.com/paritytech/cumulus/pull/2547

[ggwpez]

bot merge

[paritytech-processbot[bot]]

Waiting for commit status.

[paritytech-processbot[bot]]

Merge cancelled due to error. Error: Statuses failed for 719d26a0ead298a24486d3a3aa89ebe62d00f4f6

[KiChjang]

bot merge