substrate icon indicating copy to clipboard operation
substrate copied to clipboard

pallet-assets: Rename `total_supply` to `amount`

Open bkchr opened this issue 2 years ago • 3 comments

We are actually passing the amount on assets being minted and not the total supply.

Closes: https://github.com/paritytech/substrate/issues/13210

bkchr avatar Jan 24 '23 13:01 bkchr

Formatting failing. Wonder if we should include the label notifying an api change?

muharem avatar Jan 24 '23 15:01 muharem

Formatting failing. Wonder if we should include the label notifying an api change?

Oh yeah, we should, it will affect indexing services.

joepetrowski avatar Jan 24 '23 16:01 joepetrowski

/cmd queue -c fmt

bkchr avatar Jan 24 '23 22:01 bkchr

@bkchr https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2312203 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 45-f2dd4553-b6a8-4013-8cdc-b6f38f73eb0d to cancel this command or /cmd cancel to cancel all commands in this pull request.

command-bot[bot] avatar Jan 24 '23 22:01 command-bot[bot]

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2312203 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2312203/artifacts/download.

command-bot[bot] avatar Jan 24 '23 22:01 command-bot[bot]

bot merge

bkchr avatar Jan 25 '23 10:01 bkchr

Waiting for commit status.

Merge cancelled due to error. Error: Statuses failed for 839249a050f3d0d59078233237863f465dcf6f0a

bot merge

bkchr avatar Jan 25 '23 11:01 bkchr

Waiting for commit status.

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/substrate-developer-newsletter-february-2023-notable-updates-for-frame-devs-new-deep-dives-released-calling-builders-to-apply-to-rfps-and-bounties/2137/1

Polkadot-Forum avatar Feb 24 '23 16:02 Polkadot-Forum