substrate icon indicating copy to clipboard operation
substrate copied to clipboard

pallet-assets types.rs uses pub(super), not pub

Open kayabaNerve opened this issue 2 years ago • 0 comments

Is there an existing issue?

  • [X] I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • [X] This is not a support question.

Description of bug

pallet-assets types.rs uses pub(super), not pub, preventing any program relying on its types from reading their fields. Additionally, getters are not provided. This forces either:

A) Not using its structs, yet instead using identical copies from metadata which relies on metadata accessibility B) Offering a fork of the struct definitions

I'm unsure why these shouldn't be pub, or at least have getters, accessible. If there's a reason, please let me know. I also would've just made a PR with the change, reasoning attached, to then be told if I'm missing something without simultaneously offloading the work, except I'm unfortunately unable to make PRs, sorry.

Steps to reproduce

N/A

kayabaNerve avatar Jan 23 '23 11:01 kayabaNerve