substrate icon indicating copy to clipboard operation
substrate copied to clipboard

Nomination Pool Commission

Open rossbulat opened this issue 2 years ago • 33 comments

This PR adds commission functionality to Nomination Pools (was #12511).

New structs:

Commission and CommissionChangeRate.

New storage item:

GlobalMaxCommission: Option<Perbill>.

New calls:

set_commission, set_commission_max, set_commission_change_rate and claim_commission.

polkadot companion: https://github.com/paritytech/polkadot/pull/6264 fixes #11672.

rossbulat avatar Jan 12 '23 07:01 rossbulat

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/the-future-of-polkadot-staking/1848/1

Polkadot-Forum avatar Jan 27 '23 13:01 Polkadot-Forum

bot help

rossbulat avatar Feb 20 '23 10:02 rossbulat

Are we pursuing this PR as-is, or moving to the new approach?

kianenigma avatar Feb 20 '23 12:02 kianenigma

bot rebase

rossbulat avatar Feb 23 '23 09:02 rossbulat

bot clean

rossbulat avatar Feb 23 '23 10:02 rossbulat

bot clean

rossbulat avatar Feb 24 '23 15:02 rossbulat

bot help

rossbulat avatar Feb 24 '23 15:02 rossbulat

bot bench $ pallet dev pallet_nomination_pools

rossbulat avatar Feb 24 '23 16:02 rossbulat

bot fmt

rossbulat avatar Feb 24 '23 17:02 rossbulat

bot rebase

rossbulat avatar Feb 25 '23 16:02 rossbulat

bot rebase

rossbulat avatar Feb 26 '23 04:02 rossbulat

bot rebase

rossbulat avatar Feb 27 '23 03:02 rossbulat

bot rebase

rossbulat avatar Feb 28 '23 08:02 rossbulat

bot rebase

rossbulat avatar Mar 01 '23 06:03 rossbulat

bot help

rossbulat avatar Mar 01 '23 08:03 rossbulat

bot bench $ pallet dev pallet_nomination_pools

rossbulat avatar Mar 01 '23 08:03 rossbulat

bot rebase

rossbulat avatar Mar 04 '23 11:03 rossbulat

bot bench $ pallet dev pallet_nomination_pools

rossbulat avatar Mar 04 '23 11:03 rossbulat

bot bench $ pallet dev pallet_nomination_pools

rossbulat avatar Mar 04 '23 14:03 rossbulat

bot clean

rossbulat avatar Mar 04 '23 16:03 rossbulat

bot bench $ pallet dev pallet_nomination_pools

rossbulat avatar Mar 08 '23 16:03 rossbulat

bot rebase

rossbulat avatar Mar 14 '23 02:03 rossbulat

Rebased

bot rebase

rossbulat avatar Mar 14 '23 13:03 rossbulat

Rebased

bot merge

rossbulat avatar Mar 15 '23 04:03 rossbulat

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/discussion-on-global-maximum-commission-for-nomination-pools-on-polkadot/2325/1

Polkadot-Forum avatar Mar 15 '23 04:03 Polkadot-Forum

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-40/2468/1

Polkadot-Forum avatar Mar 30 '23 10:03 Polkadot-Forum